fix: Missing margin in E2EE room header toolbox items#35614
Merged
kodiakhq[bot] merged 4 commits intodevelopfrom Mar 27, 2025
Merged
fix: Missing margin in E2EE room header toolbox items#35614kodiakhq[bot] merged 4 commits intodevelopfrom
kodiakhq[bot] merged 4 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: a697cbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35614 +/- ##
========================================
Coverage 59.72% 59.72%
========================================
Files 2829 2829
Lines 68243 68243
Branches 15126 15126
========================================
Hits 40759 40759
Misses 24876 24876
Partials 2608 2608
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dougfabris
changed the title
dougfabris
force-pushed
the
fix/room-toolbox-e2eSetup
branch
from
1df187b to
7906efe
Compare
juliajforesti
requested changes
Mar 25, 2025
apps/meteor/client/views/room/Header/RoomToolbox/RoomToolboxE2EESetup.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/HeaderV2/RoomToolbox/RoomToolboxE2EESetup.tsx
Outdated
Show resolved
Hide resolved
juliajforesti
approved these changes
Mar 26, 2025
juliajforesti
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
before
after
Issue(s)
Steps to test or reproduce
Further comments
CORE-1048